Rely on the SDK to decide if a caption is editable or not

Need matrix-org/matrix-rust-sdk#4303 to work but not to compile.
element-hq · Nov 21, 2024 · 560a04c · 560a04c
1 parent e8af711
commit 560a04c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/...c/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListPresenter.kt b/...c/main/kotlin/io/element/android/features/messages/impl/actionlist/ActionListPresenter.kt
@@ -32,7 +32,6 @@ import io.element.android.features.messages.impl.timeline.model.event.TimelineIt
 import io.element.android.features.messages.impl.timeline.model.event.TimelineItemPollContent
 import io.element.android.features.messages.impl.timeline.model.event.TimelineItemRedactedContent
 import io.element.android.features.messages.impl.timeline.model.event.TimelineItemStateContent
-import io.element.android.features.messages.impl.timeline.model.event.TimelineItemVoiceContent
 import io.element.android.features.messages.impl.timeline.model.event.canBeCopied
 import io.element.android.features.messages.impl.timeline.model.event.canBeForwarded
 import io.element.android.features.messages.impl.timeline.model.event.canReact
@@ -155,18 +154,16 @@ class DefaultActionListPresenter @AssistedInject constructor(
                 add(TimelineItemAction.Forward)
             }
             if (timelineItem.isEditable) {
-                add(TimelineItemAction.Edit)
-            } else {
-                // Caption
-                if (timelineItem.isMine &&
-                    timelineItem.content is TimelineItemEventContentWithAttachment &&
-                    timelineItem.content !is TimelineItemVoiceContent) {
+                if (timelineItem.content is TimelineItemEventContentWithAttachment) {
+                    // Caption
                     if (timelineItem.content.caption == null) {
                         add(TimelineItemAction.AddCaption)
                     } else {
                         add(TimelineItemAction.EditCaption)
                         add(TimelineItemAction.RemoveCaption)
                     }
+                } else {
+                    add(TimelineItemAction.Edit)
                 }
             }
             if (canRedact && timelineItem.content is TimelineItemPollContent && !timelineItem.content.isEnded) {

diff --git a/...st/kotlin/io/element/android/features/messages/impl/actionlist/ActionListPresenterTest.kt b/...st/kotlin/io/element/android/features/messages/impl/actionlist/ActionListPresenterTest.kt
@@ -521,7 +521,7 @@ class ActionListPresenterTest {
             val initialState = awaitItem()
             val messageEvent = aMessageEvent(
                 isMine = true,
-                isEditable = false,
+                isEditable = true,
                 content = aTimelineItemImageContent(),
             )
             initialState.eventSink.invoke(
@@ -567,7 +567,7 @@ class ActionListPresenterTest {
             val initialState = awaitItem()
             val messageEvent = aMessageEvent(
                 isMine = true,
-                isEditable = false,
+                isEditable = true,
                 content = aTimelineItemImageContent(
                     caption = A_CAPTION,
                 ),