Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various bug fixes #7649

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Various bug fixes #7649

merged 4 commits into from
Aug 23, 2023

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Aug 22, 2023

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 30.76% and project coverage change: -0.51% ⚠️

Comparison is base (b7ffeda) 12.37% compared to head (0464ded) 11.86%.

❗ Current head 0464ded differs from pull request most recent head 021af05. Consider uploading reports for the commit 021af05 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7649      +/-   ##
===========================================
- Coverage    12.37%   11.86%   -0.51%     
===========================================
  Files         1648     1648              
  Lines       163614   163619       +5     
  Branches     67171    67127      -44     
===========================================
- Hits         20242    19412     -830     
- Misses      142707   143569     +862     
+ Partials       665      638      -27     
Flag Coverage Δ
uitests 55.04% <ø> (-0.01%) ⬇️
unittests 5.71% <30.76%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../WYSIWYGInputToolbar/WysiwygInputToolbarView.swift 0.00% <0.00%> (ø)
...otSwiftUI/Modules/Common/Util/ListBackground.swift 86.36% <ø> (-1.64%) ⬇️
Riot/Modules/Pills/PillsFormatter.swift 76.02% <80.00%> (-0.37%) ⬇️

... and 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, changelog maybe?

@stefanceriu stefanceriu merged commit 83e7229 into develop Aug 23, 2023
4 checks passed
@stefanceriu stefanceriu deleted the stefan/variousBugFixes branch August 23, 2023 13:03
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when requesting user display names for pills
2 participants