Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rebuild: include prefix when filtering with --only #850

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

rebuild: include prefix when filtering with --only #850

wants to merge 2 commits into from
+128 −7

Commits on Sep 6, 2021

  1. fix: include prefix when filtering with --only 

    The logic currently ignores a module prefix when filtering packages
passed via `--only=`. This is quite confusing: to only rebuild
something like `@theia/node-pty` we must pass `--only=node-pty`.

This commit adds a lookup using the prefixed name.
    @paul-marechal
    paul-marechal committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    64aea85 View commit details
    Browse the repository at this point in the history

  2. add tests for rebuilding scoped native modules

    @paul-marechal
    paul-marechal committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    d84d91e View commit details
    Browse the repository at this point in the history