This repository has been archived by the owner on Jun 15, 2022. It is now read-only.
Allow node_modules parent folders if init script is an absolute path #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnquintana
suggested changes
Jun 28, 2017
src/es6-init.js
Outdated
| @@ -10,7 +10,7 @@ function findPackageJson(initScript) { | |||
| // Walk up the parent directories until we find package.json. Make sure that | |||
| // we're not actually stumbling upon a parent npm package | |||
| let ret = path.join(initScript, 'package.json') | |||
| if (fs.statSyncNoException(ret) && !path.resolve(path.dirname(ret), '..').match(/[\\\/]node_modules$/i)) { | |||
| if (_fs2.default.statSyncNoException(ret) && (initScript.startsWith("/") || !_path2.default.resolve(_path2.default.dirname(ret), '..').match(/[\\\/]node_modules$/i))) { | |||
There was a problem hiding this comment.
Were these built-in module name changes intentional? There aren't any _fs2 or _path2 identifiers in this file.
|
Oh, sorry about that, my bad. Pushed the fix. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in reference to Issue #39 - Don't check for a node_modules parent if init script has an absolute path.