Graceful fallback if the renderer process can't access the remote module #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviotti
force-pushed
the
optional-remote-module
branch
from
4255dfc to
7553164
Compare
|
This seems to make the module work when setting |
Right now this module will crash when being ran on a renderer process that cannot access the `remote` module for determining a default data path. After this commit, the module will gracefully require users to call `.setDataPath()` if `remote.app` cannot be accessed. See: #155 Signed-off-by: Juan Cruz Viotti <[email protected]>
jviotti
force-pushed
the
optional-remote-module
branch
from
7553164 to
0d89a67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now this module will crash when being ran on a renderer process
that cannot access the
remotemodule for determining a default datapath. After this commit, the module will gracefully require users to
call
.setDataPath()ifremote.appcannot be accessed.See: #155
Signed-off-by: Juan Cruz Viotti [email protected]