Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: consolidate default depends/recommends for FPM targets to app-builder-lib #8637

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Oct 28, 2024

Migrates default recommends and default depends for fpm from app-builder-bin Go library to app-builder-lib JS code
https://github.com/develar/app-builder/blob/d971224691f6f48555e2a9bb327f99627893372c/pkg/package-format/fpm/fpm.go#L144-L177

This allows for great control and easier updates, such as for implementing #8019.

…p-builder-bin Go library to app-builder-lib JS code
Copy link

changeset-bot bot commented Oct 28, 2024

🦋 Changeset detected

Latest commit: 8f8cb8a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta mmaietta marked this pull request as ready for review October 28, 2024 21:12
@electron-userland electron-userland deleted a comment from netlify bot Nov 5, 2024
@mmaietta mmaietta merged commit 667ab2f into master Nov 27, 2024
11 checks passed
@mmaietta mmaietta deleted the chore/fpm-default-recommends-depends branch November 27, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants