Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: in some cases , params can end up having null or undefined items… #450

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yacineb
Copy link
Contributor

@yacineb yacineb commented Dec 2, 2024

… if it's an array. added a skip to make paramtrized queries formatting more robust

… if it's an array. added a skip to make paramtrized queries formatting more robust
@yacineb yacineb self-assigned this Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

@yacineb yacineb requested a review from samwillis December 2, 2024 10:08
@samwillis
Copy link
Collaborator

Hey @yacineb,

I'm not sure what this is fixing? If we filter out undefined and null params, and as the Postgres format method takes positional parameters, these could become unaligned?

@yacineb
Copy link
Contributor Author

yacineb commented Dec 9, 2024

@samwillis one related issue is this one: #448

@sandros94
Copy link

Not only this indeed creates a misalignment, as @samwillis pointed out, but also prevents passing nullish params, something that can be intentional.

#448 is fixable via #466 by fixing only the Vue package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants