Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pg-sync #435

Merged
merged 16 commits into from
Nov 26, 2024
Merged

fix: pg-sync #435

merged 16 commits into from
Nov 26, 2024

Conversation

yacineb
Copy link
Contributor

@yacineb yacineb commented Nov 25, 2024

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

Built bundles:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024 •
edited
Loading

🚀 Deployed on https://6745d2c62cc71f562ba518d0--pglite.netlify.app

@yacineb yacineb requested a review from samwillis November 25, 2024 19:21
samwillis
samwillis requested changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few small tweaks.

I think the mock ignores the table option, we should look at fixing that, along with e2e tests.

Let's get this merged and solve other things later.

packages/pglite-sync/example/index.html Outdated Show resolved Hide resolved
docs/docs/sync.md Outdated Show resolved Hide resolved
packages/pglite-sync/test/sync.test.ts Outdated Show resolved Hide resolved
packages/pglite-sync/test/sync.test.ts Outdated Show resolved Hide resolved
packages/pglite-sync/test/sync.test.ts Outdated Show resolved Hide resolved
packages/pglite-sync/test/sync.test.ts Outdated Show resolved Hide resolved
packages/pglite-sync/test/sync.test.ts Outdated Show resolved Hide resolved
packages/pglite-sync/test/sync.test.ts Outdated Show resolved Hide resolved
packages/pglite-sync/test/sync.test.ts Outdated Show resolved Hide resolved
docs/docs/sync.md Show resolved Hide resolved
@yacineb yacineb requested a review from samwillis November 26, 2024 09:02
@yacineb yacineb self-assigned this Nov 26, 2024
@yacineb yacineb added bug Something isn't working documentation Improvements or additions to documentation labels Nov 26, 2024
samwillis
samwillis approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks @yacineb !

I've added a changeset (you can do this on future PRs with pnpm chageset from the root of the repo) and tweaked the example read me.

@samwillis samwillis merged commit d1dd12b into main Nov 26, 2024
7 checks passed
@samwillis samwillis deleted the 432-pg-sync-fix branch November 26, 2024 13:54
@AntonOfTheWoods AntonOfTheWoods mentioned this pull request Nov 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwillis samwillis samwillis approved these changes

Assignees

@yacineb yacineb

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yacineb @samwillis