debug tidy + unix sock via files pairs #257
Conversation
|
🚀 Deployed on https://66ce00db401f1c4187b7aa5d--pglite.netlify.app |
|
was ok with debug on, retrying with off or switching to 3.1.65final |
|
also fix PGVERSION => PG_VERSION. Also will support different debug level for extension / core (CDEBUG) ( by include files and search directories for include paths ). And also allow to tune linker of core elements separately ( LDEBUG ) |
There was a problem hiding this comment.
Looks good! I see the docker image for the builder was also created, did you perhaps check that it works (top level of the repo run pnpm wasm:build)? Cause I know that the SDK building might fail without an exit code 1 so I'm worried about a dud docker image being uploaded (especially for ARM)
| @@ -348,7 +371,7 @@ then | |||
| pushd pgvector | |||
| # path for wasm-shared already set to (pwd:pg build dir)/bin | |||
| # OPTFLAGS="" turns off arch optim (sse/neon). | |||
| PG_CONFIG=${PGROOT}/bin/pg_config emmake make OPTFLAGS="" install || exit 276 | |||
There was a problem hiding this comment.
do these exit codes have any meaning or are they for debugging?
There was a problem hiding this comment.
yeah for debugging CI, fails should exit with line number seems this one has moved a while without updating :D
DEBUG=false for cibuild should close #256
unix socket emulation will allow to complety build without socket support and use C stdlib (native/wasi/emscripten) filesystem support as a unified replacement