fix(satellite): Ensure decimal point in real number encoding #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VAX-1078 Client write to a float column fails to validate on the server
Reported in Discord — https://discord.com/channels/933657521581858818/1079688869852753981/1154950112414535753. The problem happens when a whole number is written into a float column, e.g. The server explicitly checks that a float number has a decimal point and at least one place following it, e.g. The client needs to make sure that a floating point number always has a decimal point when encoded for the Satellite protocol. |
alco
force-pushed
the
alco/vax-1078-encode-real-number-with-decimal-point
branch
from
e2de116 to
a414388
Compare
alco
added a commit
that referenced
this pull request
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes VAX-1078.
Related: #507