Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(electric): Fix the {:error, :relation_missing} error that regularly causes E2E tests to fail on CI #432

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

alco
Copy link
Member

@alco alco commented Sep 15, 2023

At least with this change in place, I can no longer reproduce the error. Whereas before it would take me 2-3 runs to see it happen.

FIxes VAX-980.

@alco alco force-pushed the alco/vax-980-error-relation-missing branch 3 times, most recently from b72a61c to 28d6f77 Compare September 20, 2023 12:07
@electric-sql electric-sql deleted a comment from netlify bot Sep 20, 2023
@alco alco force-pushed the alco/vax-980-error-relation-missing branch from 1bad3c2 to bb0341f Compare September 28, 2023 14:05
@alco alco force-pushed the alco/vax-980-error-relation-missing branch from 7362034 to 6b14f5b Compare October 2, 2023 13:33
@alco alco changed the title WIP Log additional context and Client.relation_oid() fails to retrieve any rows fix(electric): Fix the {:error, :relation_missing} error that regularly causes E2E tests to fail on CI Oct 2, 2023
@alco alco marked this pull request as ready for review October 2, 2023 13:56
@alco alco requested a review from icehaunter October 2, 2023 13:56
Copy link
Contributor

@magnetised magnetised left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we had the same problem -- glad it fixed everything

@alco alco merged commit 2b24fa2 into main Oct 4, 2023
4 checks passed
@alco alco deleted the alco/vax-980-error-relation-missing branch October 4, 2023 11:09
@alco
Copy link
Member Author

alco commented Oct 4, 2023

@magnetised Nope, still happening. This is from a recent CI run on main - https://github.com/electric-sql/electric/actions/runs/6405168943/job/17387182502.

alco added a commit that referenced this pull request Oct 5, 2023
…ly causes E2E tests to fail on CI (#432)

At least with this change in place, I can no longer reproduce the error.
Whereas before it would take me 2-3 runs to see it happen.

FIxes VAX-980.

---------

Co-authored-by: Garry Hill <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants