Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (sync-service): Add documentation for optimisation tests #2089

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

robacourt
Copy link
Contributor

Follow up to #2076, based on @alco 's comments, this documents the optimisation tests.

@robacourt robacourt marked this pull request as ready for review December 3, 2024 13:56
@robacourt robacourt requested a review from alco December 3, 2024 14:06
Copy link
Member

@alco alco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

# These tests assert that the number of reductions needed to calculate the affected shapes
# when there at @shape_count shapes is less than @max_reductions.
#
# Reductions are used as a proxy for time taken for the calculation and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very neat erlang gives you access to this sort of low-level data!

@robacourt robacourt merged commit 68a26db into main Dec 3, 2024
22 of 26 checks passed
@robacourt robacourt deleted the rob/explain-reductions branch December 3, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants