Add an optional DATABASE_POOL_URL config #2085
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alco
force-pushed
the
alco/two-database-urls
branch
from
a53b820 to
afff898
Compare
When configured, the lock connection and the database pool will connect to this pooled URL. By default, when DATABASE_POOL_URL is not set, all connections are open using the direct database connection URL configured with DATABASE_URL.
alco
force-pushed
the
alco/two-database-urls
branch
from
afff898 to
63676b9
Compare
icehaunter
previously approved these changes
Dec 3, 2024
icehaunter
dismissed
their stale review
Quick demo PR, not intended for merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #1885.
When configured, the lock connection and the database pool will connect to this pooled URL.
By default, when
DATABASE_POOL_URLis not set, all connections are open using the direct database connection URL configured withDATABASE_URL.Things to add before merging: