Rename "replication lag" to "retained WAL size" #2056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-dp
reviewed
Nov 28, 2024
examples/linearlite/src/shapes.ts
Outdated
| params: { | ||
| databaseId, |
There was a problem hiding this comment.
I have an open PR for fixing this: #2055
It should actually be database_id: databaseId.
Let's not introduce it here and merge my PR instead. I did not yet merge it because deployment failed yesterday, but it's unrelated to the PR itself so we can merge now.
There was a problem hiding this comment.
I saw your PR and have since removed this change from mine.
Examples |
The thing being measured here is the size of the WAL that Electric's replication slot retains, so I think the new name describes it better. This change also restructures the code a bit to make the dependency on the DB connection pool crystal clear.
alco
force-pushed
the
alco/replication-lag
branch
from
d989268 to
540d5eb
Compare
robacourt
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thing being measured here is the size of the WAL that Electric's replication slot retains, so I think the new name describes it better.
This change also restructures the code a bit to make the dependency on the DB connection pool crystal clear.