feat! (ts client): remove databaseId option from ShapeStream
#2053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msfstef
requested changes
Nov 27, 2024
There was a problem hiding this comment.
Looks good! There is a bunch of references to database_id, commented out multi-tenant tests in the client, references to other_database, the health check in the tests uses database_id, the definition of DATABASE_ID_QUERY_PARAM itself (which you removed the reference to here), that are no longer relevant since multi-tenant does not exist and electric does not know about database IDs anymore.
Could you please clean those up as well along with this change so we no longer have references to multitenancy and database IDs in the client?
msfstef
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2052.
It removes the
databaseIdoption fromShapeStreamin favor of the more genericparamsoption.