chore (sync service): report replication lag #2043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin-dp
force-pushed
the
kevin/report-lag-size
branch
from
e1fc9ac to
ef60d00
Compare
kevin-dp
changed the title
kevin-dp
force-pushed
the
kevin/report-lag-size
branch
from
8d0444b to
a133523
Compare
icehaunter
approved these changes
Nov 26, 2024
| now = DateTime.utc_now() | ||
| lag = Kernel.max(0, DateTime.diff(now, commit_timestamp, :millisecond)) | ||
|
|
||
| OpenTelemetry.with_span( |
There was a problem hiding this comment.
should this just be an attribute on the handle transaction span?
kevin-dp
added a commit
that referenced
this pull request
Nov 26, 2024
This PR addresses [Kyle's comment](#2043 (review)) and adds the replication lag to the current span instead of creating a new span. --------- Co-authored-by: Kyle Mathews <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2031.
Note on clock drift
The replication lag in milliseconds may be affected by clock drift between Electric and Postgres. This may occur because Electric and Postgres may be running on different machines and we compare the transaction's commit timestamp (generated by PG) to Electric's timestamp at the time of writing the transaction to the shape log.