Allow for configuration of non-standard API endpoints #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use `base_url` for the old behaviour of automatically appending `/v1/shape` and `endpoint` to explictly set the full URL of the shape api
msfstef
approved these changes
Nov 19, 2024
magnetised
deleted the
1992-elixir-client-cannot-point-to-arbitrary-proxy
branch
magnetised
added a commit
that referenced
this pull request
Nov 19, 2024
Originally the /v1/shape path was appended onto the `base_url` path, but #1994 changed that to ignore any path elements in the base_url. This change un-does that and reverts back to appending the /v1/shape path onto the base_url. (no changeset included as the one in #1994 covers this) @msfstef almost backwards compatible...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use
base_urlfor the old behaviour of automatically appending/v1/shapeandendpointto explictly set the full URL of the shape apiFixes #1992