fix: do validation for params off constructor so it can throw before starting #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samwillis
approved these changes
Nov 18, 2024
Comment on lines
538
to
545
| const reservedParams = Object.keys(options.params).filter( | ||
| (key) => RESERVED_PARAMS.has(key) | ||
| ) | ||
| if (reservedParams.length > 0) { | ||
| throw new Error( | ||
| `Cannot use reserved Electric parameter names in custom params: ${reservedParams.join(`, `)}` | ||
| ) | ||
| } |
There was a problem hiding this comment.
Nit: this could be simpler?
for (const param of RESERVED_PARAMS) {
if (param in options.params) {
throw new Error(`Cannot use reserved Electric parameter name in custom params: ${param}`);
}
}
There was a problem hiding this comment.
The existing test checks all parameters before throwing an error — so the error message is more comprehensive than if you throw immediately.
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
KyleAMathews
had a problem deploying
to
Pull request
GitHub Actions
Failure
KyleAMathews
had a problem deploying
to
Pull request
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
did this wrong in #1978 so that combined with #1983, passing a reserved parameter just means it silently fails atm.