fix: also change DATABASE_ID to ELECTRIC_DATABASE_ID #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thruflo
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
I observe that we don't have this env var documented yet. Which is fine as we don't have any multi-tenancy documentation yet.
Do the potential re-factoring changes that @magnetised and @kevin-dp are discussing impact anything around the API for multi-tenancy? Or are we able to document the usage when we want to?
|
We can merge this now & they can then change it / add docs when they get to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed this when working on #1927