fix: Clear react caches when stream is errored #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyleAMathews
approved these changes
Oct 29, 2024
|
|
||
| streamCache.set(shapeHash, newShapeStream) | ||
| const newShapeStream = new ShapeStream<T>(options) |
There was a problem hiding this comment.
perhaps move this logic inside the if error clause?
There was a problem hiding this comment.
The same logic applies if there is no prior shape stream, which is why I left them outside.
- Shape stream exists
- Errored or aborted -> delete cached and create new
- Working fine -> return cached
- Shape stream does not exist
- create new
|
|
||
| shapeCache.set(shapeStream, newShape) | ||
| const newShape = new Shape<T>(shapeStream) |
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1690