Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of temporary replication slots #1896

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

msfstef
Copy link
Contributor

@msfstef msfstef commented Oct 29, 2024

Fixes #1854

For test environments it is convenient to have the option to use temporary replication slots such that no subsequent cleanup work is required.

Copy link
Contributor

@robacourt robacourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

@KyleAMathews
Copy link
Contributor

We should also document this somewhere cc @thruflo

@msfstef
Copy link
Contributor Author

msfstef commented Oct 29, 2024

I'll merge this regardless as we currently don't document the env vars anywhere - it's also worth potentially not publicly documenting functionality that we need for ourselves until someone asks for it (so we have a smaller API surface to maintain)

@msfstef msfstef merged commit c4d118d into main Oct 29, 2024
23 checks passed
@msfstef msfstef deleted the msfstef/configurable-temp-replication-slot branch October 29, 2024 15:25
KyleAMathews pushed a commit that referenced this pull request Nov 1, 2024
Fixes #1854

For test environments it is convenient to have the option to use
temporary replication slots such that no subsequent cleanup work is
required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add way to cleanup replication slots
3 participants