chore(sync-service): Decouple Timeline from ShapeCache #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2024
alco
force-pushed
the
alco/db-connection-streamlining
branch
from
1857bff to
edbbccd
Compare
alco
force-pushed
the
alco/decouple-timeline-from-shape-cache
branch
2 times, most recently
from
7ec3345 to
ae60ac5
Compare
msfstef
approved these changes
Oct 15, 2024
alco
force-pushed
the
alco/db-connection-streamlining
branch
from
edbbccd to
c14c6fe
Compare
This change reduces coupling between Timeline and ShapeCache modules, resulting in easier comprehension and maintenance of this small part of the code. ConnectionManager serves as the supervisor of the connection startup procedure and that's where we keep the knowledge about how a change in PG timeline affects the shape cache. As a bonus, we don't have to first start all shape consumers just to bring them all down afterwards, as we've been doing up until this change.
alco
force-pushed
the
alco/decouple-timeline-from-shape-cache
branch
from
ae60ac5 to
8381a60
Compare
alco
changed the title
|
Merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR chain: #1842 ← #1841 ← #1845 ← #1846 ← #1862
See individual commits to get a better idea of what this PR achieves.