feat(sync-service): Move WHERE clause evaluation to single process #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robacourt
force-pushed
the
rob/single-process-shape-filter
branch
2 times, most recently
from
93c6505 to
85ba982
Compare
KyleAMathews
approved these changes
Sep 26, 2024
|
Yep. Sounds good. |
robacourt
force-pushed
the
rob/single-process-shape-filter
branch
from
c9841a8 to
85ba982
Compare
robacourt
force-pushed
the
rob/single-process-shape-filter
branch
from
85ba982 to
4fd17d8
Compare
msfstef
pushed a commit
that referenced
this pull request
Oct 10, 2024
Follow-up to #1761 - no changeset as it fixes a bug introduced there
KyleAMathews
pushed a commit
that referenced
this pull request
Nov 1, 2024
…1761) This is the simplest change to meet the criteria of #1744 . It's faster and uses less memory: <img width="795" alt="Screenshot 2024-10-10 at 13 48 21" src="https://github.com/user-attachments/assets/a508d078-9cbd-4610-babb-909d66de682e"> Than our current version: <img width="790" alt="Screenshot 2024-10-10 at 13 48 38" src="https://github.com/user-attachments/assets/a1a0d0da-39fd-4201-b468-5aa64a649120"> Because of the reduction in memory use it can handle bigger transactions at 100k shapes: <img width="824" alt="Screenshot 2024-10-10 at 13 36 12" src="https://github.com/user-attachments/assets/da0a62f8-97c6-4dee-b63b-a8222ed54856"> vs our la <img width="822" alt="Screenshot 2024-10-10 at 13 35 59" src="https://github.com/user-attachments/assets/2f7aec8b-e840-49ba-b4b7-2d4733b264f9"> test version:
KyleAMathews
pushed a commit
that referenced
this pull request
Nov 1, 2024
Follow-up to #1761 - no changeset as it fixes a bug introduced there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest change to meet the criteria of #1744 .
It's faster and uses less memory:
Than our current version:
Because of the reduction in memory use it can handle bigger transactions at 100k shapes:
vs our la
test version: