chore (sync-service): run filter logic for PG version 15 in unit tests #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alco
reviewed
Sep 12, 2024
There was a problem hiding this comment.
This works fine locally, but fails on CI when Postgres 14 is used. To fix that CI job, the hard-coded version needs to be replaced by a setting looked up at runtime.
I think it'd be best to add an environment variable POSTGRES_MAJOR_VERSION for both CI jobs and look it up in config/runtime.exs inside a conditional block:
if config_env() == :test do
config :electric, major_pg_version_for_tests: env!("POSTGRES_MAJOR_VERSION", :integer, 15)
end
Then in the test code you can fetch the setting via Application.fetch_env!(:electric, :major_pg_version_for_tests).
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
KyleAMathews
pushed a commit
that referenced
this pull request
Nov 1, 2024
#1672) This modifies the unit tests to use the publication filter logic for PG 15 as that is more advanced than the logic for version 14 and below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the unit tests to use the publication filter logic for PG 15 as that is more advanced than the logic for version 14 and below.