Fix null value parsing

[dustin-H]

Hi there,

first of all, I really like your project! Amazing work! 🚀
Thank you!

While integrating it I found a bug:
When a shape includes a column, that is nullable and currently null or set to null, the typescript client is crashing:

The code is checking if the typeof value is object and is then trying to iterate over it's keys.
However, typeof null is also object. This is why it crashes here, as it cannot iterate over null.
This PR fixes #1673.

A simple check for null fixes this as proposed in this PR.

Could you please merge it? Or is there anything I've overseen?
Thanks!

[KyleAMathews]

Hey thanks for reporting and fixing the issue!

Could you also add a test for the issue? Lemme know if you need help running the tests. The contribution docs are immature still.

[dustin-H]

@KyleAMathews Thanks for your quick reply.

I just wrote a test, made the check more precise and added a comment to explain why the check for null is required.

If you run the test without my change, it will fail with the error posted above.

[kevin-dp]

Hi @dustin-H,

Thanks for contributing this PR.
After taking a closer look, i think the test is wrong (see my comment there) because the message is ill-formed. As a result, the fix is fixing something that cannot occur.

You're referring to a bug:

While integrating it I found a bug:
When a shape includes a column, that is nullable and currently null or set to null, the typescript client is crashing

Could you open an issue with a reproduction for this please?
We have unit tests that check that null values are parsed correctly, but perhaps we are missing a corner case. Feel free to contribute that test case if you want.

[dustin-H]

Hi @kevin-dp,

you are right. I accidentally created the test with an invalid message, which led to the same result as the correct one.

I created the issue you requested: #1673

I also fixed the test to match the message I mean.

[kevin-dp]

Fixes #1673.

[kevin-dp]

Thank you for contributing the test case we were missing for columns named "value" and providing the fix 💯