Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: let users add custom parameters #1978

Merged
merged 1 commit into from
Nov 15, 2024
Merged

feat: let users add custom parameters #1978

merged 1 commit into from
Nov 15, 2024

Conversation

KyleAMathews
Copy link
Contributor

e.g.

const streamWithParams = new ShapeStream({
  url: `${BASE_URL}/v1/shape`,
  table: `foo`,
  params: {
    'custom-param': 'value'
  }
})

@netlify Netlify
Copy link

netlify bot commented Nov 14, 2024

✅ Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit 6c1af21
🔍 Latest deploy log https://app.netlify.com/sites/electric-next/deploys/673686a48716d4000893f6bf
😎 Deploy Preview https://deploy-preview-1978--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

balegas
balegas approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@balegas balegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@KyleAMathews
Copy link
Contributor Author

I'll merge tomorrow & update the examples @balegas

thruflo
thruflo approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@thruflo thruflo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and nice improvement to the docs 👍

@KyleAMathews KyleAMathews merged commit a99b94c into main Nov 15, 2024
25 checks passed
@KyleAMathews KyleAMathews deleted the custom-params branch November 15, 2024 14:43
@KyleAMathews KyleAMathews mentioned this pull request Nov 16, 2024
Merged
KyleAMathews added a commit that referenced this pull request Nov 18, 2024
@KyleAMathews
fix: do validation for params off constructor so it can throw before …
91e5b85 
…starting (#1984)

did this wrong in #1978 so that combined with #1983, passing a reserved
parameter just means it silently fails atm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balegas balegas balegas approved these changes

@thruflo thruflo thruflo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyleAMathews @thruflo @balegas