Refactor subscribing to stack events

electric-sql · Nov 21, 2024 · a2597da · a2597da
1 parent 41ae9a6
commit a2597da
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/packages/sync-service/lib/electric/plug/utils.ex b/packages/sync-service/lib/electric/plug/utils.ex
@@ -140,7 +140,7 @@ defmodule Electric.Plug.Utils do
     stack_events_registry = conn.assigns.config[:stack_events_registry]
 
     ref = make_ref()
-    Registry.register(stack_events_registry, {:stack_status, stack_id}, ref)
+    Electric.StackSupervisor.subscribe_to_stack_events(stack_events_registry, stack_id, ref)
 
     if Electric.ProcessRegistry.alive?(stack_id, Electric.Replication.Supervisor) do
       conn

diff --git a/packages/sync-service/lib/electric/stack_supervisor.ex b/packages/sync-service/lib/electric/stack_supervisor.ex
@@ -87,6 +87,10 @@ defmodule Electric.StackSupervisor do
     end
   end
 
+  def subscribe_to_stack_events(registry, stack_id, value) do
+    Registry.register(registry, {:stack_status, stack_id}, value)
+  end
+
   def dispatch_stack_event(registry, stack_id, event) do
     Registry.dispatch(registry, {:stack_status, stack_id}, fn entries ->
       for {pid, ref} <- entries do

diff --git a/packages/sync-service/test/support/component_setup.ex b/packages/sync-service/test/support/component_setup.ex
@@ -170,7 +170,7 @@ defmodule Support.ComponentSetup do
     stack_events_registry = Registry.StackEvents
 
     ref = make_ref()
-    Registry.register(stack_events_registry, {:stack_status, stack_id}, ref)
+    Electric.StackSupervisor.subscribe_to_stack_events(stack_events_registry, stack_id, ref)
 
     stack_supervisor =
       start_supervised!(