Shield pooled connections from exceptions in user functions

electric-sql · Oct 2, 2023 · 83f9876 · 83f9876
1 parent ee9adcb
commit 83f9876
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/components/electric/lib/electric/postgres/connection_pool.ex b/components/electric/lib/electric/postgres/connection_pool.ex
@@ -32,13 +32,21 @@ defmodule Electric.Postgres.ConnectionPool do
     NimblePool.checkout!(
       pool,
       :checkout,
-      fn _pool, conn ->
-        {fun.(conn), :ok}
-      end,
+      fn _pool, conn -> {execute_fun_with_conn(fun, conn), :ok} end,
       @pool_timeout
     )
   end
 
+  defp execute_fun_with_conn(fun, conn) do
+    try do
+      fun.(conn)
+    rescue
+      e ->
+        Logger.error(Exception.format(:error, e, __STACKTRACE__))
+        {:error, e}
+    end
+  end
+
   @spec name(Connectors.origin()) :: Electric.reg_name()
   def name(origin) when is_binary(origin) do
     Electric.name(__MODULE__, origin)