Query major PG version.

electric-sql · Sep 11, 2024 · 22d9cff · 22d9cff
1 parent 307b64b
commit 22d9cff
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/packages/sync-service/lib/electric/connection_manager.ex b/packages/sync-service/lib/electric/connection_manager.ex
@@ -159,7 +159,7 @@ defmodule Electric.ConnectionManager do
       {:ok, pid} ->
         Electric.Timeline.check(get_pg_timeline(pid), state.timeline_opts)
 
-        pg_version = query_pg_version(pid)
+        pg_version = query_pg_major_version(pid)
 
         # Now we have everything ready to start accepting and processing logical messages from
         # Postgres.
@@ -397,11 +397,11 @@ defmodule Electric.ConnectionManager do
     end
   end
 
-  def query_pg_version(conn) do
+  def query_pg_major_version(conn) do
     [[setting]] =
       Postgrex.query!(
         conn,
-        "SELECT setting::decimal FROM pg_settings WHERE name = 'server_version'",
+        "SELECT floor(setting::numeric)::integer FROM pg_settings WHERE name = 'server_version'",
         []
       )
       |> Map.fetch!(:rows)

diff --git a/packages/sync-service/test/electric/postgres/configuration_test.exs b/packages/sync-service/test/electric/postgres/configuration_test.exs
@@ -235,7 +235,7 @@ defmodule Electric.Postgres.ConfigurationTest do
   end
 
   defp list_tables_in_publication(conn, publication) do
-    pg_version = Electric.ConnectionManager.query_pg_version(conn)
+    pg_version = Electric.ConnectionManager.query_pg_major_version(conn)
     list_tables_in_pub(conn, publication, pg_version)
   end
 

diff --git a/packages/sync-service/test/support/db_setup.ex b/packages/sync-service/test/support/db_setup.ex
@@ -49,7 +49,7 @@ defmodule Support.DbSetup do
   end
 
   def with_pg_version(ctx) do
-    pg_version = Electric.ConnectionManager.query_pg_version(ctx.db_conn)
+    pg_version = Electric.ConnectionManager.query_pg_major_version(ctx.db_conn)
     {:ok, %{get_pg_version: fn -> pg_version end}}
   end