Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icp ecosystem changes #779

Closed
wants to merge 5 commits into from

Conversation

Mohdniyam
Copy link
Contributor

No description provided.

Copy link
Contributor

@eherrerosj eherrerosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments

url = "https://github.com/sameer152005/privad"

[[repo]]
url = "https://github.com/Preeti-2507/TO-DO"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how's this repo using ICP?

url = "https://github.com/SURYANSHI-WEB/coven"

[[repo]]
url = "https://github.com/Sagarshah2004/Recipes"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can probably remove

url = "https://github.com/AAshu1412/ICP-Blockchain-Calculator"

[[repo]]
url = "https://github.com/abhinav-nav/dakepper"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how's this ICP?

@Mohdniyam
Copy link
Contributor Author

Thank for reviewing @eherrerosj , I have checked the repo list again and made the suggested changes as well as removed other unnecessary repos.

Copy link
Contributor

@eherrerosj eherrerosj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked a subset of the repos you are removing and I'm a bit confused on why they should be removed provided that they do build on top of ICP

url = "https://github.com/diwakarsha/satworkshop"

[[repo]]
url = "https://github.com/AkshatBhatnagar29/blockbashhack"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this repo being removed? It is actually ICP, no?

url = "https://github.com/gurleenkaur164/gurleen"

[[repo]]
url = "https://github.com/Nishesh-singla/Blockchain"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this repo being removed? It is using actually ICP, no?

url = "https://github.com/Anshikarathour64/sat_blockchain"

[[repo]]
url = "https://github.com/diwakarsha/satworkshop"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this repo being removed? It is using actually ICP, no?

url = "https://github.com/AkshatBhatnagar29/blockbashhack"

[[repo]]
url = "https://github.com/gurleenkaur164/gurleen"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this repo being removed? It is using actually ICP, no?

@Mohdniyam
Copy link
Contributor Author

@eherrerosj , I have reverted the unnecessary removal of repos, this happened due to not taking proper pull requests from master. Hope we are good to go now.

@jubos
Copy link
Collaborator

jubos commented Dec 23, 2023

Manually merged with bdfaebb

@jubos jubos closed this Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants