Make --upgrade safer by failing fast if transcrypt config cannot be r…

…ead #189
elasticdog · Jan 4, 2025 · 2607610 · 2607610
1 parent 016b2e4
commit 2607610
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -34,6 +34,11 @@ system, you must also run the `--upgrade` command in each repository:
 
 ## [Unreleased]
 
+### Fixed
+
+- Make --upgrade safer by failing fast if transcrypt config cannot be read
+  (#189)
+
 ## [2.3.0] - 2024-09-10
 
 ### Added

diff --git a/transcrypt b/transcrypt
@@ -920,6 +920,11 @@ uninstall_transcrypt() {
 
 # uninstall and re-install transcrypt to upgrade scripts and update configuration
 upgrade_transcrypt() {
+	# Fail with an error if we cannot read the existing config
+	if [[ ! $INSTALLED_VERSION ]]; then
+		die 1 'no existing transcrypt configuration found'
+	fi
+
 	if [[ $interactive ]]; then
 		printf 'You are about to upgrade the transcrypt scripts in your repository.\n'
 		printf 'Your configuration settings will not be changed.\n\n'