Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: use obltmachine for tagging and creating the release in the release workflow #948

Merged
merged 2 commits into from
Aug 27, 2024
Merged

ci: use obltmachine for tagging and creating the release in the release workflow #948

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1712dff
Use obltmachine for tagging in the release workflow
reakaleek Aug 27, 2024
31ecfd8
Add missing places where we need to use the PAT
reakaleek Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ on:
default: false

permissions:
contents: write # needed to push the tag and create the release
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed anymore because we use the PAT of @obltmachine

id-token: write # to enable use of OIDC for npm provenance

jobs:
Expand All @@ -27,7 +26,11 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: elastic/apm-pipeline-library/.github/actions/setup-git@current
token: ${{ secrets.RELEASE_GITHUB_TOKEN }}

- uses: elastic/oblt-actions/git/setup@v1
with:
github-token: ${{ secrets.RELEASE_GITHUB_TOKEN }}
- run: npm ci # runs npm prepublish

- name: configure NPMJS token
Expand All @@ -36,7 +39,7 @@ jobs:
- run: npx semantic-release --dry-run="${DRY_RUN}"
env:
DRY_RUN: ${{ github.event.inputs.dry-run }}
GITHUB_TOKEN: ${{ github.token }}
GITHUB_TOKEN: ${{ secrets.RELEASE_GITHUB_TOKEN }}

- name: Get version and package name
run: |
Expand Down
Loading