address pr comment

elastic · Jan 22, 2024 · 9d64e0a · 9d64e0a
1 parent 9fede70
commit 9d64e0a
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/pkg/httpserver/config.go b/pkg/httpserver/config.go
@@ -8,6 +8,7 @@ import (
 	"encoding/json"
 	"errors"
 	"os"
+	"strings"
 	"text/template"
 
 	ucfg "github.com/elastic/go-ucfg"
@@ -102,6 +103,9 @@ func file(path string) (string, error) {
 }
 
 func minify(body string) (string, error) {
-	b, err := json.Marshal(json.RawMessage(body))
-	return string(b), err
+	var buf strings.Builder
+	enc := json.NewEncoder(&buf)
+	enc.SetEscapeHTML(false)
+	err := enc.Encode(json.RawMessage(body))
+	return strings.TrimSpace(buf.String()), err
 }
diff --git a/pkg/httpserver/httpserver_test.go b/pkg/httpserver/httpserver_test.go
@@ -63,7 +63,7 @@ func TestHTTPServer(t *testing.T) {
           {{ minify_json ` + "`" + `
           {
           	"key1": "value1",
-          	"key2": "value2"
+          	"key2": "<value2>"
           }
           ` + "`" + `}}
 `
@@ -162,7 +162,7 @@ func TestHTTPServer(t *testing.T) {
 		require.NoError(t, err)
 		resp.Body.Close()
 
-		assert.Equal(t, `{"key1":"value1","key2":"value2"}`, string(body))
+		assert.Equal(t, `{"key1":"value1","key2":"<value2>"}`, string(body))
 	})
 }