introduce go.mod for env2yaml #15921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 Build Succeeded
|
|
@logstashmachine backport 8.12 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
Update the env2yaml to have a go.mod instead of relying on disabling go modules, otherwise building with golang 1.22 will fail in the future. This change also directly uses the golang image to build the binary removing the need for an intermediate image. (cherry picked from commit 5c3e64d)
jsvd
added a commit
that referenced
this pull request
Feb 8, 2024
Update the env2yaml to have a go.mod instead of relying on disabling go modules, otherwise building with golang 1.22 will fail in the future. This change also directly uses the golang image to build the binary removing the need for an intermediate image. (cherry picked from commit 5c3e64d) Co-authored-by: João Duarte <[email protected]>
|
@logstashmachine backport 7.17 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
Update the env2yaml to have a go.mod instead of relying on disabling go modules, otherwise building with golang 1.22 will fail in the future. This change also directly uses the golang image to build the binary removing the need for an intermediate image. (cherry picked from commit 5c3e64d)
jsvd
added a commit
that referenced
this pull request
Feb 8, 2024
Update the env2yaml to have a go.mod instead of relying on disabling go modules, otherwise building with golang 1.22 will fail in the future. This change also directly uses the golang image to build the binary removing the need for an intermediate image. (cherry picked from commit 5c3e64d) Co-authored-by: João Duarte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the env2yaml to have a go.mod instead of relying on disabling go modules, otherwise building with golang 1.22 will fail.
This change also directly uses the golang image to build the binary removing the need for an intermediate image.
Tested locally and also with buildkite build docker image:
fixes #15920