Fix docker build issues #15919
Closed
Fix docker build issues #15919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't pin the minor version of the go docker image and the recent update to 1.22 resulted in the following error: ``` go env -w GO111MODULE=off && go get gopkg.in/yaml.v2 go: modules disabled by GO111MODULE=off; see 'go help modules' ``` This commit pins the Go docker image to 1.21 until we resolve the issue in a more proper manner (using go modules) in a follow up PR.
|
|
The SonarQube analysis reports https://sonar.elastic.dev/security_hotspots?id=elastic_logstash_AYm_nEbQaV3I-igkX1q9&pullRequest=15919&inNewCodePeriod=true i.e.
but since this is a builder image step just for building env2yaml, and it's not a new issue introduced by this PR, I think we are ok. @jsvd for thoughts. |
💚 Build Succeeded
cc @dliappis |
|
Superseded by https://github.com/elastic/logstash/pull/15921/files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
We don't pin the minor version of the go docker
image and the recent update to 1.22 resulted in
the following error:
This commit pins the Go docker image to 1.21
until we resolve the issue in a more proper manner (using go modules) in a follow up PR.
Why is it important/What is the impact to the user?
Unblocks DRA and CI.
How to test this PR locally
DRA snapshot build link (main): https://buildkite.com/elastic/logstash-dra-snapshot-pipeline/builds/495
Related issues
#15920