Backport PR #15861 to 7.17: Allow running Java+Ruby tests on Windows separately #15887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This commit allows separate running of Java and Ruby tests on Windows i.e. the same way as we currently do on unix (unit_tests.sh) via a cli argument. If no argument has been supplied, both tests are run (as it does now). The wrapper script is also rewritten from old batch style script to Powershell. This work allows us to split the existing Windows CI job in a subsequent PR to separate steps, as we currently do on Linux. Relates: #15566 (cherry picked from commit 8ac5518)
💚 Build Succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport PR #15861 to 7.17 branch, original message:
Release notes
[rn:skip]
What does this PR do?
This commit allows separate running of Java and Ruby tests on Windows i.e. the same way as we currently do on unix (
unit_tests.sh) via a cli argument.If no argument has been supplied, both tests are run (as it does now).
The wrapper script is also rewritten from old batch style script to powershell.
Why is it important/What is the impact to the user?
It allows us to split the existing Windows CI job in a subsequent PR to separate steps, as we currently do for Linux.
How to test this PR locally
Launch Windows VM using https://github.com/elastic/ingest-dev/blob/main/engineer-productivity/tools/launch_windows_vm.sh
launch powershell.
Git clone this PR and run:
.\ci\unit_tests.ps1 java(or skip the argument to run all)To simulate a failure you can revert c33afd4
Example successful run on Buildkite:
Simulating a failure:
I temporarily reverted the muted Windows test to verify that a failure bubbles up as a test failure:
Related issues