Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute DLQ test on Windows #15843

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

dliappis
Copy link
Contributor

@dliappis dliappis commented Jan 23, 2024

Release notes

[rn:skip]

What does this PR do?

This commit mutes the DLQ test:
testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty when running on Windows.

How to test this PR locally

Using this PR:

Example windows build: https://buildkite.com/elastic/logstash-windows-jdk-matrix-pipeline/builds/82#_
Example Linux build: https://buildkite.com/elastic/logstash-pull-request-pipeline/builds/754#018d376b-b614-4fa2-9a63-d8433bcc1207

Related issues

This commit mutes the DLQ test:
`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
when running on Windows.

Closes elastic#15768
@dliappis dliappis self-assigned this Jan 23, 2024
Copy link

@dliappis dliappis marked this pull request as ready for review January 23, 2024 18:05
@dliappis dliappis requested a review from andsel January 23, 2024 18:05
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @dliappis

Copy link
Contributor

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Fix request already tracked by #15767

@dliappis dliappis merged commit c33afd4 into elastic:main Jan 24, 2024
5 checks passed
@dliappis
Copy link
Contributor Author

@logstashmachine backport 8.12

github-actions bot pushed a commit that referenced this pull request Jan 24, 2024
This commit mutes the DLQ test:
`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
when running on Windows.

Closes #15768

(cherry picked from commit c33afd4)
@dliappis
Copy link
Contributor Author

As discussed in #15768 (comment), this test existed only in 8.4.0, so we are only going to backport to 8.12 and not 7.17.

dliappis added a commit that referenced this pull request Jan 24, 2024
This commit mutes the DLQ test:
`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
when running on Windows.

Closes #15768

(cherry picked from commit c33afd4)

Co-authored-by: Dimitrios Liappis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore test testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty on WIndows
4 participants