Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore test testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty on WIndows #15768

Closed
andsel opened this issue Jan 9, 2024 · 2 comments · Fixed by #15843
Closed

Comments

@andsel
Copy link
Contributor

andsel commented Jan 9, 2024

Given that the test DeadLetterQueueWriterAgeRetentionTest .testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty fails only on Windows platform, ignore selectively the test for that environment.
For example, with JUnit4 we could leverage the Assume and at the start of the test:

@Test
public void testSomething() {
    assumeThat(getOsName(), is(not("Windows")));
    // testing code
}
@dliappis
Copy link
Contributor

In case it could be a useful data point, wanted to share that we don't observe Windows failures with the 7.17 branch: https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds?branch=7.17

@andsel
Copy link
Contributor Author

andsel commented Jan 10, 2024

Thanks @dliappis for checking it, I think it's due to the fact that the age retention policy feature (#14255) and tests were introduced in 8.4.0

dliappis added a commit to dliappis/logstash that referenced this issue Jan 23, 2024
This commit mutes the DLQ test:
`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
when running on Windows.

Closes elastic#15768
dliappis added a commit that referenced this issue Jan 24, 2024
This commit mutes the DLQ test:
`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
when running on Windows.

Closes #15768
github-actions bot pushed a commit that referenced this issue Jan 24, 2024
This commit mutes the DLQ test:
`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
when running on Windows.

Closes #15768

(cherry picked from commit c33afd4)
dliappis added a commit that referenced this issue Jan 24, 2024
This commit mutes the DLQ test:
`testDLQWriterFlusherRemovesExpiredSegmentWhenCurrentHeadSegmentIsEmpty`
when running on Windows.

Closes #15768

(cherry picked from commit c33afd4)

Co-authored-by: Dimitrios Liappis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants