Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Windows CI JDK Matrix job to Java and Ruby #15566

Closed
1 of 2 tasks
dliappis opened this issue Nov 10, 2023 · 0 comments · Fixed by #15861 or #15888
Closed
1 of 2 tasks

Split Windows CI JDK Matrix job to Java and Ruby #15566

dliappis opened this issue Nov 10, 2023 · 0 comments · Fixed by #15861 or #15888
Assignees
@dliappis
Labels
ci

Comments

@dliappis
Copy link
Contributor

dliappis commented Nov 10, 2023 •
edited
Loading

Tasks

Tasks
Beta Give feedback

Description

Background: #15563 (comment)

Currently the unit test script for Windows (

logstash/ci/unit_tests.bat

Line 51 in 5af14f4

call .\gradlew.bat test --console=plain --no-daemon --info
) runs both Java and Ruby tests and doesn't provide a way to select the suite.

We should enhance the script to allow selecting the suite similarly to how it's possible in the Unix counterpart:

logstash/ci/unit_tests.sh

Lines 40 to 45 in 5af14f4

echo "Running Java Tests"
./gradlew javaTests "${SONAR_ARGS[@]}" --console=plain --warning-mode all
elif [[ $SELECTED_TEST_SUITE == $"ruby" ]]; then
echo "Running Ruby unit tests"
./gradlew rubyTests --console=plain --warning-mode all
else

and also split the Windows group to have two steps in the group.

While at it we could also modernize the script and rewrite it in Powershell rather than the old batch file format.
@dliappis dliappis added the ci label Nov 10, 2023
@dliappis dliappis self-assigned this Nov 10, 2023
@dliappis dliappis mentioned this issue Nov 10, 2023
Merged
5 tasks
dliappis added a commit to dliappis/logstash that referenced this issue Jan 26, 2024
@dliappis
Allow running Java+Ruby tests on Windows separately
2ca189b 
This commit allows separate running of Java and Ruby tests on Windows
i.e. the same way as we currently do on unix (`unit_tests.sh`)
via a cli argument.

If no argument has been supplied, both tests are run (as it does now).

The wrapper script is also rewritten from old batch style script to
powershell.

Relates elastic#15566
@dliappis dliappis mentioned this issue Jan 26, 2024
Merged
@dliappis dliappis linked a pull request Jan 29, 2024 that will close this issue
Allow running Java+Ruby tests on Windows separately #15861
Merged
dliappis added a commit that referenced this issue Feb 1, 2024
@dliappis
Allow running Java+Ruby tests on Windows separately (#15861)
8ac5518 
This commit allows separate running of Java and Ruby tests on Windows i.e. the same way as we currently do on unix (unit_tests.sh) via a cli argument.
If no argument has been supplied, both tests are run (as it does now).

The wrapper script is also rewritten from old batch style script to Powershell.

This work allows us to split the existing Windows CI job in a subsequent PR to separate steps, as we currently do on Linux.

Relates: #15566
github-actions bot pushed a commit that referenced this issue Feb 1, 2024
@dliappis @logstashmachine
Allow running Java+Ruby tests on Windows separately (#15861)
ef8451e 
This commit allows separate running of Java and Ruby tests on Windows i.e. the same way as we currently do on unix (unit_tests.sh) via a cli argument.
If no argument has been supplied, both tests are run (as it does now).

The wrapper script is also rewritten from old batch style script to Powershell.

This work allows us to split the existing Windows CI job in a subsequent PR to separate steps, as we currently do on Linux.

Relates: #15566
(cherry picked from commit 8ac5518)
@github-actions github-actions bot mentioned this issue Feb 1, 2024
Merged
github-actions bot pushed a commit that referenced this issue Feb 1, 2024
@dliappis @logstashmachine
Allow running Java+Ruby tests on Windows separately (#15861)
ebfcd0a 
This commit allows separate running of Java and Ruby tests on Windows i.e. the same way as we currently do on unix (unit_tests.sh) via a cli argument.
If no argument has been supplied, both tests are run (as it does now).

The wrapper script is also rewritten from old batch style script to Powershell.

This work allows us to split the existing Windows CI job in a subsequent PR to separate steps, as we currently do on Linux.

Relates: #15566
(cherry picked from commit 8ac5518)
@github-actions github-actions bot mentioned this issue Feb 1, 2024
Merged
dliappis added a commit to dliappis/logstash that referenced this issue Feb 1, 2024
@dliappis
Split java/ruby unit test steps on Windows
2e7a3cd 
As a follow up to elastic#15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes elastic#15566
dliappis added a commit that referenced this issue Feb 1, 2024
@github-actions @dliappis
Allow running Java+Ruby tests on Windows separately (#15861) (#15886)
07216a4 
This commit allows separate running of Java and Ruby tests on Windows i.e. the same way as we currently do on unix (unit_tests.sh) via a cli argument.
If no argument has been supplied, both tests are run (as it does now).

The wrapper script is also rewritten from old batch style script to Powershell.

This work allows us to split the existing Windows CI job in a subsequent PR to separate steps, as we currently do on Linux.

Relates: #15566
(cherry picked from commit 8ac5518)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this issue Feb 1, 2024
@github-actions @dliappis
Allow running Java+Ruby tests on Windows separately (#15861) (#15887)
3420d4c 
This commit allows separate running of Java and Ruby tests on Windows i.e. the same way as we currently do on unix (unit_tests.sh) via a cli argument.
If no argument has been supplied, both tests are run (as it does now).

The wrapper script is also rewritten from old batch style script to Powershell.

This work allows us to split the existing Windows CI job in a subsequent PR to separate steps, as we currently do on Linux.

Relates: #15566
(cherry picked from commit 8ac5518)

Co-authored-by: Dimitrios Liappis <[email protected]>
@dliappis dliappis mentioned this issue Feb 1, 2024
Merged
@dliappis dliappis reopened this Feb 2, 2024
dliappis added a commit that referenced this issue Mar 11, 2024
@dliappis
Split java/ruby unit test steps on Windows (#15888)
c0c213d 
As a follow up to #15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes #15566
github-actions bot pushed a commit that referenced this issue Mar 11, 2024
@dliappis @logstashmachine
Split java/ruby unit test steps on Windows (#15888)
f772239 
As a follow up to #15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes #15566

(cherry picked from commit c0c213d)
@github-actions github-actions bot mentioned this issue Mar 11, 2024
Merged
github-actions bot pushed a commit that referenced this issue Mar 11, 2024
@dliappis @logstashmachine
Split java/ruby unit test steps on Windows (#15888)
bf9d006 
As a follow up to #15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes #15566

(cherry picked from commit c0c213d)
@github-actions github-actions bot mentioned this issue Mar 11, 2024
Merged
github-actions bot pushed a commit that referenced this issue Mar 11, 2024
@dliappis @logstashmachine
Split java/ruby unit test steps on Windows (#15888)
375c570 
As a follow up to #15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes #15566

(cherry picked from commit c0c213d)
@github-actions github-actions bot mentioned this issue Mar 11, 2024
Merged
dliappis added a commit that referenced this issue Mar 11, 2024
@github-actions @dliappis
Split java/ruby unit test steps on Windows (#15888) (#15992)
3e7f095 
As a follow up to #15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes #15566

(cherry picked from commit c0c213d)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this issue Mar 11, 2024
@github-actions @dliappis
Split java/ruby unit test steps on Windows (#15888) (#15993)
3c94369 
As a follow up to #15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes #15566

(cherry picked from commit c0c213d)

Co-authored-by: Dimitrios Liappis <[email protected]>
dliappis added a commit that referenced this issue Mar 11, 2024
@github-actions @dliappis
Split java/ruby unit test steps on Windows (#15888) (#15994)
8c23b10 
As a follow up to #15861 this commit splits the current unit tests step
for the Windows JDK matrix pipeline to two that run
Java and Ruby unit tests separately.

Closes #15566

(cherry picked from commit c0c213d)

Co-authored-by: Dimitrios Liappis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dliappis dliappis

Labels
ci
Projects
None yet
Milestone
No milestone
1 participant
@dliappis