Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][MySQL] Update README to clarify the supported setup information for replica_status data stream #11861

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

harnish-elastic
Copy link
Contributor

@harnish-elastic harnish-elastic commented Nov 25, 2024

Proposed commit message

Update README to clarify the supported setup information for replica_status data stream.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Related issues

@harnish-elastic harnish-elastic added documentation Improvements or additions to documentation Integration:mysql MySQL Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Nov 25, 2024
@harnish-elastic harnish-elastic self-assigned this Nov 25, 2024
@harnish-elastic harnish-elastic marked this pull request as ready for review November 25, 2024 10:16
@harnish-elastic harnish-elastic requested a review from a team as a code owner November 25, 2024 10:16
@andrewkroh andrewkroh added the enhancement New feature or request label Nov 25, 2024
@shmsr shmsr changed the title [O11y][MySQL] Update README to clarify the supported setup information for replica_status data stream [O11y][MySQL] Update README to clarify the supported setup information for replica_status data stream Nov 25, 2024
packages/mysql/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/mysql/docs/README.md Outdated Show resolved Hide resolved
packages/mysql/changelog.yml Outdated Show resolved Hide resolved
@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@shmsr
Copy link
Member

shmsr commented Nov 25, 2024

Oh wait. You have referenced MySQL 8.4 docs. But if you see the supported versions:

|replica_status|5.7,8.0.22|10.4,10.5.1|5.7,8.0.22|

Max supported is 8.0.22 in our package. Can you quickly check if nothing changed much between 8.0.x and 8.4.x?

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @harnish-elastic

@harnish-elastic
Copy link
Contributor Author

Oh wait. You have referenced MySQL 8.4 docs. But if you see the supported versions:

|replica_status|5.7,8.0.22|10.4,10.5.1|5.7,8.0.22|

Max supported is 8.0.22 in our package. Can you quickly check if nothing changed much between 8.0.x and 8.4.x?

@shmsr Checked, no major updates between 8.0.x and 8.4.x, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request Integration:mysql MySQL Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[O11y][MySQL] Update documentation for replica_status data stream
4 participants