Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Integration for Missile Map #11758

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

navnit-crest
Copy link

@navnit-crest navnit-crest commented Nov 18, 2024

Proposed commit message

Create a new integration package named missile_map and add the Missile Map dashboard.

The Missile Map dashboard includes a custom map visualization that uses the Elastic Map Service to add a base map. For the marks (path, text, arc, etc.) and animations, it uses the Vega visualization framework within Kibana.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

  1. Clone integrations repo.
  2. Install elastic package locally.
  3. Start elastic stack using elastic-package.
  4. Move to integrations/packages/missile_map directory.
  5. Run the following command to run tests.

elastic-package test

--- Test results for package: missile_map - START ---
╭─────────────┬─────────────┬───────────┬──────────────────────────────────────────────────────────────────────┬────────┬──────────────╮
│ PACKAGE     │ DATA STREAM │ TEST TYPE │ TEST NAME                                                            │ RESULT │ TIME ELAPSED │
├─────────────┼─────────────┼───────────┼──────────────────────────────────────────────────────────────────────┼────────┼──────────────┤
│ missile_map │             │ asset     │ dashboard missile_map-c881478e-1b94-4dd1-846b-db92277f94fb is loaded │ PASS   │        960ns │
╰─────────────┴─────────────┴───────────┴──────────────────────────────────────────────────────────────────────┴────────┴──────────────╯
--- Test results for package: missile_map - END   ---
Done

Screenshots

missile-map

Copy link

cla-checker-service bot commented Nov 18, 2024

💚 CLA has been signed

@andrewkroh andrewkroh added needs CLA User must sign the Elastic Contributor License before review. New Integration labels Nov 18, 2024
navnit-crest and others added 3 commits November 19, 2024 16:19
Update README

Update time window to last 30 minutes

Update DSL query to sort data based on existance of geo location fields

Update animation speed to uniform across all paths
@andrewkroh andrewkroh removed the needs CLA User must sign the Elastic Contributor License before review. label Nov 19, 2024
@navnit-crest navnit-crest marked this pull request as ready for review November 25, 2024 06:08
@navnit-crest navnit-crest changed the title [Draft] Add Integration for Missile Map Add Integration for Missile Map Nov 25, 2024
@kcreddy
Copy link
Contributor

kcreddy commented Nov 25, 2024

/test

@kcreddy kcreddy added the Crest label Nov 25, 2024
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is complianing on missing CODEOWNERS entry.

Add an entry inside .github/CODEOWNERS file here:

/packages/missle_map @elastic/security-service-integrations

packages/missile_map/LICENSE.txt Outdated Show resolved Hide resolved
packages/missile_map/manifest.yml Outdated Show resolved Hide resolved
packages/missile_map/manifest.yml Outdated Show resolved Hide resolved
packages/missile_map/manifest.yml Outdated Show resolved Hide resolved
packages/missile_map/manifest.yml Outdated Show resolved Hide resolved
packages/missile_map/docs/README.md Show resolved Hide resolved
packages/missile_map/docs/README.md Outdated Show resolved Hide resolved
packages/missile_map/docs/README.md Outdated Show resolved Hide resolved
packages/missile_map/docs/README.md Outdated Show resolved Hide resolved
packages/missile_map/manifest.yml Outdated Show resolved Hide resolved
@kcreddy kcreddy added the Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] label Nov 25, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy kcreddy added the dashboard Relates to a Kibana dashboard bug, enhancement, or modification. label Nov 25, 2024
navnit-crest and others added 2 commits November 25, 2024 15:15
Add entry in CODEOWNERS for missile map

Remove LICENSE.txt

Modify minimum Kibana version contraint to 8.14.0

Update README.md
@kcreddy
Copy link
Contributor

kcreddy commented Nov 25, 2024

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

Comment on lines +2 to +5
name: missile_map
title: Missile Map
version: 0.1.0
description: "This integration ships a missile map, a custom visualization to analyze network traffic data."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Package name and description requires a change. Holding off merge until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crest dashboard Relates to a Kibana dashboard bug, enhancement, or modification. New Integration Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants