1password - fix system test preserve_original_event #11554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system tests for 1password place the preserve_original_event configuration option into the the top-level vars instead of the per data_stream vars where the variable is declared. The sample events generated by the system tests did not contain the 'event.original' field as a result.
[git-generate] elastic-package -C packages/1password test system -g elastic-package -C packages/1password build
andrewkroh
force-pushed
the
1password/bugfix/sample-event-original
branch
from
c6df340
to
2dc48fc
Compare
💚 Build Succeeded
|
|
andrewkroh
added
the
Team:Security-Service Integrations
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6
approved these changes
Oct 28, 2024
|
The fact that this is accepted probably means the It is something that elastic-package could validate. Surprisingly, there are only two levels of variables listed in the code1 when there are four levels of specifying variables in packages (integration, policy template, policy template input, data stream). I'll open an issue. Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message