[8.x](backport #6437) fix(6023): replace list with items #6459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* fix(6023): replace list with items * fix(6023): added changelog * fix(6023): added test validating the new items matches the deprecated list * fix(6023): added comment to better trace where the integration test comes from The integration test added in this pull request needs to be removed once the list component is removed from the kibana api * fixs(6023): ran mage update * fix(6023): add build tag to integration test * fix(6023): added unit test for kibanaFetchToken * fix(6023): added error checks in unit test (cherry picked from commit 68d5833)
mergify
bot
requested review from
andrzej-stencel and
pchila
and removed request for
a team
jlind23
approved these changes
Dec 31, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces
listwithitemsfrom fromkibanaFetchTokenas thelistis deprecated in the api response and will be removed.Why is it important?
The
listin the api response is going to be removed in favor ofitemChecklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog toolDisruptive User Impact
There shouldn't be any user impact
How to test this PR locally
Related issues
listproperty when retrieving enrollment api keys #6023validate_items_deprecated_list_test.gointegration test #6451This is an automatic backport of pull request #6437 done by [Mergify](https://mergify.com).