Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a different branch name for the auto-updates #6335

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Dec 13, 2024

What does this PR do?

Rename the branch name created for the automation

Why is it important?

Avoid matching branches enrolled to the branch protection.

For instance, #6318 was created using 8.x-update-agent-versions-12303810957, and there is a branch protection for 8.*; therefore, it has some constraints about PR development.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This should avoid issues with matching branch protection rules
@v1v v1v requested a review from a team as a code owner December 13, 2024 18:03
@v1v v1v requested review from rdner and cmacknz December 13, 2024 18:03
@v1v v1v self-assigned this Dec 13, 2024
Copy link
Contributor

mergify bot commented Dec 13, 2024

This pull request does not have a backport label. Could you fix it @v1v? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Dec 13, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 13, 2024
@v1v v1v added skip-changelog backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Dec 13, 2024
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@v1v v1v enabled auto-merge (squash) December 15, 2024 09:56
@v1v v1v merged commit 83a12c2 into main Dec 16, 2024
11 of 13 checks passed
@v1v v1v deleted the v1v-patch-1 branch December 16, 2024 10:22
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
rdner pushed a commit that referenced this pull request Dec 16, 2024
(cherry picked from commit 83a12c2)

Co-authored-by: Victor Martinez <[email protected]>
rdner pushed a commit that referenced this pull request Dec 16, 2024
(cherry picked from commit 83a12c2)

Co-authored-by: Victor Martinez <[email protected]>
rdner pushed a commit that referenced this pull request Dec 16, 2024
(cherry picked from commit 83a12c2)

Co-authored-by: Victor Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants