Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run providers that are referenced in the policy #6169

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

blakerouse
Copy link
Contributor

@blakerouse blakerouse commented Nov 28, 2024

What does this PR do?

This updates the Elastic Agent to only run composable providers if they are referenced in the policy.

Why is it important?

This change provides the following benefits:

  • Reduces the memory and load of the Elastic Agent, by only running the providers it references.
  • No longer requires access to the kubernetes API or resources just to run an Elastic Agent (as long as its not using any ${kubernetes*` references in the policy).
  • Fixes an issue where if no providers are running that a set of empty variables is passed to the coordinator.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test (covered by unit tests)

Disruptive User Impact

None. As it still runs all those that are referenced from the user.

How to test this PR locally

Run the elastic-agent container with just the system integration and notice that it doesn't require access to the Kubernetes API any more.

Related issues

@blakerouse blakerouse self-assigned this Nov 28, 2024
Copy link
Contributor

mergify bot commented Nov 28, 2024

This pull request does not have a backport label. Could you fix it @blakerouse? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Nov 28, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 28, 2024
@blakerouse blakerouse changed the title [DRAFT] Run only providers that are referenced in the policy Only run providers that are referenced in the policy Nov 29, 2024
@blakerouse blakerouse added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Nov 29, 2024
@blakerouse blakerouse marked this pull request as ready for review November 29, 2024 00:37
@blakerouse blakerouse requested a review from a team as a code owner November 29, 2024 00:37
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, had some questions about the design and intended control flow.

internal/pkg/agent/transpiler/ast.go Show resolved Hide resolved
internal/pkg/agent/transpiler/ast.go Outdated Show resolved Hide resolved
internal/pkg/agent/transpiler/ast.go Show resolved Hide resolved
internal/pkg/composable/controller.go Outdated Show resolved Hide resolved
internal/pkg/composable/controller.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
3 participants