Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run BK integration tests on PRs and release branches #6148

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Nov 26, 2024

What does this PR do?

Runs the new integration testing infrastructure provisioned by buildkite and terraform (ESS)

Integration tests take 1 h 10 minutes instead of ~1:30.

Independent test groups execution allows to retry tests independently with a dedicated ESS stack:
Screenshot 2024-11-27 at 16 43 16

Build example 1
Build example 2
Build example 3
Build example 4

We run the same tests as we run in the OGC integration tests

What groups do we run

  • default
  • container
  • fleet-upgrade-to-pr-build
  • upgrade
  • fleet
  • fqdn
  • deb
  • fleet-airgapped
  • fleet-privileged
  • fleet-airgapped-privileged
  • rpm

What OS do we run

  • Windows 2022
  • Ubuntu 24.04 x86_64
  • Ubuntu 24.04 ARM (temporarily disabled due to a known issue)
  • RHEL 8 (rpm)

By comparing test reports, I verified that we run the same test sets for groups. Placed the tests in groups in this spreadsheet

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cut over cannot occur until this pipeline is generated.

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pazone pazone marked this pull request as ready for review November 28, 2024 13:58
@pazone pazone requested review from a team as code owners November 28, 2024 13:58
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@pazone pazone requested a review from cmacknz November 28, 2024 14:21

When creating a new test group, it is important to add the new group to the job in the `.buildkite/bk.integration.pipeline.yml` file. This will ensure that the new group is executed in the CI pipeline.

Add the new group to the `matrix` in the corresponding steps. The matrix is a list of all the test groups that are executed in the teh step.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understood the sentence though.

Suggested change
Add the new group to the `matrix` in the corresponding steps. The matrix is a list of all the test groups that are executed in the teh step.
Add the new group to the `matrix` in the corresponding steps. The matrix is a list of all test groups that are executed in the step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants