Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fleet deprecated list property when retrieving enrollment api keys #6023

Closed
nchaulet opened this issue Nov 13, 2024 · 3 comments · Fixed by #6437
Closed

Fleet deprecated list property when retrieving enrollment api keys #6023

nchaulet opened this issue Nov 13, 2024 · 3 comments · Fixed by #6437
Assignees
@kaanyalti
Labels
bug Something isn't working good first issue Good for newcomers Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@nchaulet
Copy link
Member

The list property in GET /api/fleet/enrollment_api_keys as been deprecated since 8.0.0 in favor of the items property

This should be changed in:

https://github.com/elastic/elastic-agent/blob/4b15e1afa8de457fe34ce35d2215180d625b4fe0/internal/pkg/agent/cmd/container.go#L954`

Related to https://github.com/elastic/ingest-dev/issues/4459
@nchaulet nchaulet added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Nov 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@ycombinator ycombinator added the good first issue Good for newcomers label Nov 15, 2024
@ycombinator
Copy link
Contributor

@nchaulet Is the list property going to go away starting with 9.0.0?

@nchaulet
Copy link
Member Author

@nchaulet Is the list property going to go away starting with 9.0.0?

Yes it is supposed to be removed in 9.0.0

This was referenced Dec 25, 2024
Merged
Open
@mergify mergify bot mentioned this issue Dec 31, 2024
Merged
4 tasks
@kaanyalti kaanyalti mentioned this issue Dec 31, 2024
Draft
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaanyalti kaanyalti

Labels
bug Something isn't working good first issue Good for newcomers Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(6023): replace list with items kaanyalti/elastic-agent
4 participants
@ycombinator @nchaulet @elasticmachine @kaanyalti