Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint to RFC 5424 in log.syslog.severity.name and log.syslog.severity.code #2291

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

fgierlinger
Copy link
Contributor

This PR updates the description of log.syslog.severity.name and log.syslog.severity.code to explicitly name the allowed values according to RFC 5424.

  • Have you signed the contributor license agreement? Yes
  • Have you followed the contributor guidelines? Yes
  • For proposing substantial changes or additions to the schema, have you reviewed the RFC process? Yes
  • If submitting code/script changes, have you verified all tests pass locally using make test? Yes
  • If submitting schema/fields updates, have you generated new artifacts by running make and committed those changes? Yes
  • Is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed. Yes
  • Have you added an entry to the CHANGELOG.next.md? Yes

@fgierlinger fgierlinger requested a review from a team as a code owner October 6, 2023 19:36
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Documentation changes preview: https://ecs_2291.docs-preview.app.elstc.co/diff

Copy link

github-actions bot commented Dec 6, 2023

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Stale issues and pull requests label Dec 6, 2023
@andrewkroh andrewkroh requested a review from a team December 7, 2023 02:43
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we limiting to RFC 5424? RFC 3164 has the same values, so we could say "RFC 3164/RFC 5424".

@fgierlinger
Copy link
Contributor Author

@efd6 RFC 3164 has been obsoleted by RFC 5424

@efd6
Copy link
Contributor

efd6 commented Dec 8, 2023

Yeah I was just thinking that if people are reading this and they know that they have syslogs coming in in that format, but are not aware of the fact, they could be confused. We do have data sources that use the BSD format and we support it.

@github-actions github-actions bot removed the stale Stale issues and pull requests label Dec 9, 2023
Copy link

github-actions bot commented Feb 8, 2024

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Stale issues and pull requests label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants