Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect reusable.top_level in Beats generator #2278

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Respect reusable.top_level in Beats generator #2278

merged 6 commits into from
Sep 25, 2023

Conversation

ebeahan
Copy link
Member

@ebeahan ebeahan commented Sep 20, 2023

Remove field sets with reusable.top_level: false from erroneously appearing as valid, top-level fields in generated/beats/fields.ecs.yml.

The same check is now performed on both the ES template and Beats fields generators.

Fixes #2277

@ebeahan ebeahan requested a review from a team as a code owner September 20, 2023 18:53
@ebeahan ebeahan self-assigned this Sep 20, 2023
kgeller
kgeller approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@kgeller kgeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebeahan ebeahan merged commit 7c374fe into elastic:main Sep 25, 2023
1 check passed
@ebeahan ebeahan deleted the beats-top-level-handling branch September 25, 2023 16:32
@chemamartinez chemamartinez mentioned this pull request Nov 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgeller kgeller kgeller approved these changes

Assignees

@ebeahan ebeahan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect generated/beats/fields.ecs.yml, not accounting on top_level: false
2 participants
@ebeahan @kgeller