Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add TAV tests for pino and winston supported versions #160

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

trentm
Copy link
Member

@trentm trentm commented Oct 25, 2023

We support pino@6, pino@7, pino@8, and winston@3.

Refs: #131
Refs: #115


This adds "TAV" (test-all-versions) tests to test against supported versions of pino and winston. I didn't bother with morgan because there hasn't been a new release of it for years. CI is setup to run this once per week.

We support pino@6, pino@7, pino@8, and winston@3.

Refs: #131
Refs: #115
@trentm trentm self-assigned this Oct 25, 2023
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Oct 25, 2023
@trentm
Copy link
Member Author

trentm commented Oct 25, 2023

Here are npm run tav runs for pino and winston using node v16:

% npm run tav

> @elastic/[email protected] tav
> tav --quiet

-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with pino (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with pino (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with pino (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with pino (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with pino (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with pino (env: {})
-- ok

I did manually do a run with all pino versions, but that's too
many versions.

% npm run tav

> @elastic/[email protected] tav
> tav --quiet

-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "npm test" with winston (env: {})
-- ok

@david-luna david-luna merged commit c6ac65d into main Oct 26, 2023
9 checks passed
@david-luna david-luna deleted the trentm/tav-tests branch October 26, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants